From c7567fb4cc0a0a10fde539edceeb4f9377765efc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?H=C3=A9ctor=20Hurtado?= Date: Fri, 11 Sep 2020 11:18:11 +0200 Subject: [PATCH] Fix getSSLClietnDN returns DN instead CN --- internal/server/data/resource.go | 2 +- internal/server/data/resource_test.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/server/data/resource.go b/internal/server/data/resource.go index af14b490..61894d6a 100644 --- a/internal/server/data/resource.go +++ b/internal/server/data/resource.go @@ -168,7 +168,7 @@ func getSSLClietnDN(w http.ResponseWriter, r *http.Request, h *model.Handler) { httperror.ErrorJSON(w, ResourceItemNotFound, http.StatusNotFound) } else { w.Header().Add("Content-Type", "application/octet-stream") - _, _ = w.Write([]byte(h.Request.TLS.VerifiedChains[0][0].Subject.CommonName)) + _, _ = w.Write([]byte(h.Request.TLS.VerifiedChains[0][0].Subject.String())) } } diff --git a/internal/server/data/resource_test.go b/internal/server/data/resource_test.go index e19e324f..e1db6c1d 100644 --- a/internal/server/data/resource_test.go +++ b/internal/server/data/resource_test.go @@ -1237,8 +1237,8 @@ func TestGetSSLClientDNReturnsCorrectDN(t *testing.T) { res := w.Result() - if body, _ := ioutil.ReadAll(res.Body); string(body) != h.Request.TLS.VerifiedChains[0][0].Subject.CommonName { - t.Errorf("Body mismatch. Expected: %q, got: %q", h.Request.TLS.VerifiedChains[0][0].Subject.CommonName, string(body)) + if body, _ := ioutil.ReadAll(res.Body); string(body) != h.Request.TLS.VerifiedChains[0][0].Subject.String() { + t.Errorf("Body mismatch. Expected: %q, got: %q", h.Request.TLS.VerifiedChains[0][0].Subject.String(), string(body)) } }