Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review design of kapow server init process #95

Closed
nilp0inter opened this issue Nov 25, 2019 · 1 comment
Closed

Review design of kapow server init process #95

nilp0inter opened this issue Nov 25, 2019 · 1 comment
Labels
discussion things to discuss about
Milestone

Comments

@nilp0inter
Copy link
Contributor

nilp0inter commented Nov 25, 2019

  1. kapow server is artificially coupled to /bin/sh which maybe not present in all supported systems.
  2. A file format for rule exchange may be desirable.
  3. We will NOT discuss this until we discuss this.
@hhurtado
Copy link
Contributor

Duplicate of #83, #62 and #64. Will continue here and close the others.

kapowCMD := exec.Command("bash", powfile)

The idea is to decouple from bash and to execute directly the path given to the kapow server command and delegate in the OS the task of identifying what is the best option.

This will allow to remove the .pow extension and replace it with a better one that let the OS to choose and/or to include inside the file a shebang to instruct the interpreter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion things to discuss about
Projects
None yet
Development

No branches or pull requests

2 participants