Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom WP notify plugin #684

Closed
alex-418 opened this issue Aug 13, 2019 · 7 comments
Closed

Remove custom WP notify plugin #684

alex-418 opened this issue Aug 13, 2019 · 7 comments

Comments

@alex-418
Copy link
Contributor

Ensure there's no other functionality disabled when removing this plugin. Deprecate repository, remove from dependencies.

@alex-418 alex-418 self-assigned this Aug 13, 2019
@alex-418
Copy link
Contributor Author

Documenting code to be removed from template to avoid fatal errors after https://github.com/BCcampus/custom-wp-notify has been removed.

echo do_shortcode('[cwp_notify_em_cat]');

echo do_shortcode( '[cwp_notify_em_user_cat]' );

@alex-418
Copy link
Contributor Author

Also remove email notification checkbox on signup page:
notifications

@alex-418
Copy link
Contributor Author

@paulagaube @kkilbey this is now on cert, ready for validation. The plugin is disabled, as is any functionality or wording associated with this in myEYPD and the registration page. Please let me know if you encounter any issues with these. Thanks @dshaykewich for pushing this to cert.

@alex-418 alex-418 removed their assignment Aug 14, 2019
@paulagaube paulagaube self-assigned this Aug 14, 2019
@paulagaube
Copy link

paulagaube commented Aug 14, 2019

I have verified that the email notification checkbox is no longer showing up on the Sign up page as expected. And it does not show up on the Learner profile.

@paulagaube
Copy link

Also have confirmed that the plugin at this location is now gone:
eypd.bccampus.ca > Dashboard > Settings > Custom WP Notify

This looks good, @alex-418 !

The Sign Up page seems less cluttered too, even though this is only one field.

@paulagaube paulagaube removed their assignment Aug 14, 2019
@alex-418
Copy link
Contributor Author

Awesome, thanks @paulagaube

@alex-418
Copy link
Contributor Author

@dshaykewich @paulagaube @kkilbey FYI - this is now done in prod as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants