Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEE2 v4.37.0 uses wrong file selection dialog when adding games #1358

Open
vrad-exe opened this issue Jul 23, 2020 · 3 comments
Open

BEE2 v4.37.0 uses wrong file selection dialog when adding games #1358

vrad-exe opened this issue Jul 23, 2020 · 3 comments
Labels
Bug Something isn't working correctly UI Issue pertains to the BEE2.4 user interface

Comments

@vrad-exe
Copy link
Member

When adding a game, the old Windows 95 file selection dialog is shown. This does not allow directly typing in paths for some bizarre reason, making it a pain to use for this purpose. It also does not follow the system theme on Windows 10.
image
This is a regression from the previous release, where the correct modern version was used.

@vrad-exe vrad-exe added Bug Something isn't working correctly UI Issue pertains to the BEE2.4 user interface labels Jul 23, 2020
@LautaroL20
Copy link
Member

This is a regression from the previous release, where the correct modern version was used.

Would this cause issue as seen on #1211 ? We need to be careful on this as not all the Beemod community uses Windows 10.

@vrad-exe
Copy link
Member Author

That issue had nothing to do with Windows 10, it happened there too. The problem was that the modern version of that dialog couldn't appear before the main window was open, which doesn't seem to be the case here (since it used to work fine).

@vrad-exe
Copy link
Member Author

I checked this and the incorrect dialog seems to only appear when adding the first game. That makes this indeed seem like a side effect of fixing #1211, making all of the dialogs use the old style instead of only the name entry one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working correctly UI Issue pertains to the BEE2.4 user interface
Projects
None yet
Development

No branches or pull requests

2 participants