Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll of Warp not consumed if it is dropped or its inventory slot changes #21

Open
FM-96 opened this issue May 12, 2022 · 0 comments
Open

Comments

@FM-96
Copy link
Contributor

FM-96 commented May 12, 2022

Steps to reproduce

  1. Activate an attuned Scroll of Warp.
  2. During the teleport delay either drop the used Scroll on the ground, or just move it to a different slot in your inventory.
  3. The teleport will go through, but the Scroll will not be consumed. If it was dropped, it remains on the floor. If it was moved to a different inventory slot, it remains in that slot.

Proposed solution

I'm not familiar with Spigot's API, so I don't know if it's easy/possible to keep track of an item after it's been moved.

An alternative solution would be that the teleport gets canceled if you stop holding the Scroll of Warp during the delay (just like if you step off a teleporter). Especially when dropping the Scroll entirely, this would make more sense to me than the Scroll you're no longer holding successfully teleporting you.

Another alternative would be to consume the Scroll of Warp immediately upon starting the teleport. If you don't want the teleport to be cancelable, this seems like the easiest solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant