Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The daily quota is not fullly respected if close to limit. #3073

Closed
lfield opened this issue Mar 28, 2019 · 0 comments · Fixed by #3089
Closed

The daily quota is not fullly respected if close to limit. #3073

lfield opened this issue Mar 28, 2019 · 0 comments · Fixed by #3089

Comments

@lfield
Copy link
Contributor

lfield commented Mar 28, 2019

@davidpanderson I have been using the result of PR #3024 and each day when n_jobs_today is reset to 0, the host will receive more than 1 job even though max_jobs_per_day = 1. This results in n_jobs_today > max_jobs_per_day. From looking at the code, it seems that the check n_jobs_today < max_jobs_per_day is done quite early on but when it comes to actually selecting the tasks to send, this limit is not considered. Either the selection of tasks should include a check so that it stops when the limit is reached or the number of tasks to be selected is changed based on comparison with the limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants