Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

easily invalid #7

Closed
commonpike opened this issue Oct 16, 2018 · 0 comments
Closed

easily invalid #7

commonpike opened this issue Oct 16, 2018 · 0 comments

Comments

@commonpike
Copy link

referring to https://github.com/BR0kEN-/jTap/issues/4

code says, .on nativeEvent.end

// Coordinates, when event ends, should be the same as they were
// on start.
(
     eventData.pageX === eventData.event.pageX &&
     eventData.pageY === eventData.event.pageY
)

so your finger can not slip a pixel.
other libs use ~10px.

in effect, you get a pseudo-hover state on mobile without getting a tap event fairly often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant