Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unit Types onto models #3163

Closed
nstephenh opened this issue Mar 29, 2024 · 1 comment · Fixed by #3168
Closed

Add Unit Types onto models #3163

nstephenh opened this issue Mar 29, 2024 · 1 comment · Fixed by #3168
Assignees

Comments

@nstephenh
Copy link
Contributor

nstephenh commented Mar 29, 2024

Add unit types and subtypes onto models. I've started this in #3160.

Consider removing them from units, unless we really need them on units for something like "cannot select units with the infantry keyword"

Add missing unit types in

Clean up "Vehicle" and "Vehicle Unit"

@nstephenh nstephenh self-assigned this Mar 29, 2024
@nstephenh
Copy link
Contributor Author

Most of the unit types are now handled, but there are still a few for consideration:
Fortification
Building
Deathwing, dreadwing, firewing
Psy-automata

And then a large number of misspellings of infantry, one misspelling of transport, and one transport with an asterisk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant