Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change JavaScript Promise from '.then' style to 'async-await' style in Line 105-114 of 'src/routes/apps/labelcopier/index.js' #63

Open
dongskyler opened this issue Dec 29, 2020 · 0 comments
Open

Change JavaScript Promise from '.then' style to 'async-await' style in Line 105-114 of 'src/routes/apps/labelcopier/index.js' #63

dongskyler opened this issue Dec 29, 2020 · 0 comments
Labels
complexity: 2 Complexity 2 out of 5 with 5 being the highest good first issue Good for newcomers help wanted Extra attention is needed lang: javascript status: available Issues that are up for grab type: enhancement Improve existing features

Comments

@dongskyler
Copy link
Member

dongskyler commented Dec 29, 2020 •
edited
Loading

Task

Change JavaScript Promise from '.then' style to 'async-await' style in Line 105 - 114

Tips:

  • '.then' blocks will be replaced by 'async-await' blocks
  • '.catch' blocks will be replaced by 'try-catch' blocks

Impact

The code will be more readable and more maintainable, as 'async-await' style results in cleaner and shorter code blocks.

More info

If you don't know how to do it, try to search for it. There are many good references, such as this one on Stack Overflow.

Should you have any questions, please don't hesitate to comment under this issue.
@dongskyler dongskyler added complexity: 2 Complexity 2 out of 5 with 5 being the highest good first issue Good for newcomers help wanted Extra attention is needed lang: javascript status: available Issues that are up for grab type: enhancement Improve existing features labels Dec 29, 2020
@dongskyler dongskyler changed the title Change JavaScript Promise from '.then' style to async-await style in 'src/routes/apps/labelcopier/index.js' Change JavaScript Promise from '.then' style to async-await style in Line 105-114 of 'src/routes/apps/labelcopier/index.js' Dec 29, 2020
@dongskyler dongskyler changed the title Change JavaScript Promise from '.then' style to async-await style in Line 105-114 of 'src/routes/apps/labelcopier/index.js' Change JavaScript Promise from '.then' style to 'async-await' style in Line 105-114 of 'src/routes/apps/labelcopier/index.js' Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
complexity: 2 Complexity 2 out of 5 with 5 being the highest good first issue Good for newcomers help wanted Extra attention is needed lang: javascript status: available Issues that are up for grab type: enhancement Improve existing features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dongskyler