Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parameters of external procedure call are not parsed #171

Closed
eglekaz opened this issue Sep 4, 2024 · 6 comments
Closed

parameters of external procedure call are not parsed #171

eglekaz opened this issue Sep 4, 2024 · 6 comments
Assignees
@eglekaz
Labels
blocked by 🌳 Blocked by tree-sitter implementation bug Something isn't working

Comments

@eglekaz
Copy link
Collaborator

eglekaz commented Sep 4, 2024

Example:
run getMyNumber.p(piFirstNum, piSecNum).

Calls for internal procedures are being parsed correctly.

Reference:
https://documentation.progress.com/output/ua/OpenEdge_latest/pdsoe/PLUGINS_ROOT/com.openedge.pdt.langref.help/rfi1424920323961.html
@eglekaz eglekaz self-assigned this Sep 4, 2024
@eglekaz eglekaz added the blocked by 🌳 Blocked by tree-sitter implementation label Sep 4, 2024
@eglekaz
Copy link
Collaborator Author

eglekaz commented Sep 4, 2024 •
edited
Loading

Registered: usagi-coffee/tree-sitter-abl#65

@PauliusKu
Copy link
Collaborator

@eglekaz is it a big issue for us or can we set it to P3 and maybe close on tree-sitter side as to not bother Kamil?

@eglekaz
Copy link
Collaborator Author

eglekaz commented Sep 4, 2024

I will investigate it tomorrow, if it breaks our formatting anyhow

@eglekaz
Copy link
Collaborator Author

eglekaz commented Sep 5, 2024

It is causing an error, but this error does not seem to be interrupting our formatting.

Closed the issue on tree-sitter side and moving to P3

@eglekaz eglekaz added bug Something isn't working to create 🌳 Create and link tree-sitter ticket blocked by 🌳 Blocked by tree-sitter implementation and removed blocked by 🌳 Blocked by tree-sitter implementation to create 🌳 Create and link tree-sitter ticket labels Sep 5, 2024
This was referenced Sep 11, 2024
Merged
Closed
@PauliusKu
Copy link
Collaborator

PauliusKu commented Sep 19, 2024 •
edited
Loading

I see it was fixed on tree-sitter side, can we close this ticket? @eglekaz

@eglekaz
Copy link
Collaborator Author

eglekaz commented Sep 23, 2024

Tested.
Fixed with 0.0.39 version of tree-sitter-abl

@eglekaz eglekaz closed this as completed Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eglekaz eglekaz

Labels
blocked by 🌳 Blocked by tree-sitter implementation bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PauliusKu @eglekaz