Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds Android SDK docs #19

Merged
merged 10 commits into from
Jan 4, 2023
Merged

feat: Adds Android SDK docs #19

merged 10 commits into from
Jan 4, 2023

Conversation

dhudec
Copy link
Contributor

@dhudec dhudec commented Jan 3, 2023

Description

  • Adds docs for Android SDK around collecting data with elements
  • Adds callouts to join private beta program for reveal on mobile (ios and android)

Testing required outside of automated testing?

  • Not Applicable

Screenshots (if appropriate):

https://developers-basistheory-com-git-eng-3955-basis-theory.vercel.app/docs/sdks/mobile/android/

Rollback / Rollforward Procedure

  • Roll Forward
  • Roll Back

Reviewer Checklist

  • Description of Change
  • Description of outside testing if applicable.
  • Description of Roll Forward / Backward Procedure
  • Documentation updated for Change

@dhudec dhudec requested a review from a team as a code owner January 3, 2023 21:22
@vercel
Copy link

vercel bot commented Jan 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
developers-basistheory-com ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 4, 2023 at 8:33PM (UTC)

Comment on lines 38 to 39
for collecting credit card data and [TextElement](/docs/sdks/web/javascript/types##text-element) for collecting arbitrary textual data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These links are going to JavaScript elements pages. They should be updated to point to Android elements links.


The `BasisTheoryElements` class contains methods for interacting with the Basis Theory API using element references.

### Instantiation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use the term Initialization everywhere else. Any reason we choose Instantiation here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it is around instantiation of a class and not the sdk itself. I can change the word, but I think this is a different context than elsewhere

@bweber bweber merged commit 9d36210 into master Jan 4, 2023
@bweber bweber deleted the eng-3955 branch January 4, 2023 21:07
bt-platform-eng pushed a commit that referenced this pull request Jan 4, 2023
# [1.5.0](v1.4.0...v1.5.0) (2023-01-04)

### Features

* Adds Android SDK docs ([#19](#19)) ([9d36210](9d36210))
@bt-platform-eng
Copy link

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

JustJordanT pushed a commit that referenced this pull request Jan 6, 2023
JustJordanT pushed a commit that referenced this pull request Jan 6, 2023
# [1.5.0](v1.4.0...v1.5.0) (2023-01-04)

### Features

* Adds Android SDK docs ([#19](#19)) ([9d36210](9d36210))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants