Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Eng 4024 java sdk re #29

Merged
merged 15 commits into from
Jan 23, 2023
Merged

feat: Eng 4024 java sdk re #29

merged 15 commits into from
Jan 23, 2023

Conversation

JustJordanT
Copy link
Contributor

@JustJordanT JustJordanT commented Jan 10, 2023 •
edited
Loading

Description

  • feat: added java sdk doc ref

Testing required outside of automated testing?

  • Not Applicable

Screenshots (if appropriate):

  • Not Applicable

Rollback / Rollforward Procedure

  • Roll Forward
  • Roll Back

Reviewer Checklist

  • Description of Change
  • Description of outside testing if applicable.
  • Description of Roll Forward / Backward Procedure
  • Documentation updated for Change

@JustJordanT
parent 2838d93
ad2d247 
author Jordan <Jordantay9014@outlook.com> 1672347669 -0600
committer Jordan <Jordantay9014@outlook.com> 1673381335 -0600

added java sdk and api ref
@JustJordanT
rebase
f4b8908
@JustJordanT JustJordanT self-assigned this Jan 10, 2023
@vercel
Copy link

vercel bot commented Jan 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
developers-basistheory-com ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 23, 2023 at 3:36PM (UTC)

@JustJordanT JustJordanT marked this pull request as ready for review January 10, 2023 20:52
@JustJordanT JustJordanT requested a review from a team as a code owner January 10, 2023 20:52
amkera
amkera previously approved these changes Jan 12, 2023
View reviewed changes
jleon15
jleon15 reviewed Jan 12, 2023
View reviewed changes
docs/api/logs.mdx Outdated Show resolved Hide resolved
dhudec
dhudec reviewed Jan 21, 2023
View reviewed changes
docs/sdks/server-side/java.mdx Outdated

Please follow the [installation](#installation) instruction and execute the following Java code:

```csharp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```csharp
```java

dhudec
dhudec reviewed Jan 21, 2023
View reviewed changes
docs/sdks/server-side/java.mdx Outdated
}

dependencies {
implementation 'com.basistheory:basistheory-java:0.2.1'
Copy link
Contributor

@dhudec dhudec Jan 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have the build for basistheory-java set up to update this version automatically as we do in the README in that repo, so this will go stale pretty quickly. Automating that is worth considering eventually, but for now I'd just remove the version number and link to the repo and give instructions to look up the latest version from there.

@JustJordanT JustJordanT merged commit 22e0d14 into master Jan 23, 2023
@JustJordanT JustJordanT deleted the ENG-4024-java-sdk-re branch January 23, 2023 15:41
bt-platform-eng pushed a commit that referenced this pull request Jan 23, 2023
@semantic-release-bot
chore(release): 1.19.0 [skip ci]
28f6eb9 
# [1.19.0](v1.18.0...v1.19.0) (2023-01-23)

### Features

* Eng 4024 java sdk re ([#29](#29)) ([22e0d14](22e0d14))
@bt-platform-eng
Copy link

🎉 This PR is included in version 1.19.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleon15 jleon15 jleon15 left review comments

@dhudec dhudec dhudec approved these changes

@amkera amkera amkera left review comments

Assignees

@JustJordanT JustJordanT

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JustJordanT @bt-platform-eng @dhudec @jleon15 @amkera