-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: documenting sessions #31
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sidebars.js
Outdated
@@ -261,6 +261,7 @@ const sidebars = { | |||
"api/tokens/token-associations", | |||
], | |||
}, | |||
"api/sessions", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be nested under applications nav item.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But why? The api routes for sessions are not nested under applications and sessions are separate from applications. I feel like if we want to group them together we should change the top level from Applications to something like Access Controls and nest Sessions, Applications, and Permissions all underneath
GH won't let me comment on an unchanged line.. so here: This line should probably change to say
|
sidebars.js
Outdated
items: ["api/applications/permissions"], | ||
items: [ | ||
"api/applications/permissions", | ||
"api/sessions" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move the doc under the applications folder also so grouping matches?
# [1.11.0](v1.10.0...v1.11.0) (2023-01-11) ### Features * documenting sessions ([#31](#31)) ([d732633](d732633))
🎉 This PR is included in version 1.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
Testing required outside of automated testing?
Screenshots (if appropriate):
Rollback / Rollforward Procedure
Reviewer Checklist