From 950322f3206a0354563eecaf7b79674b2e1545d9 Mon Sep 17 00:00:00 2001
From: Basti Ortiz <39114273+BastiDood@users.noreply.github.com>
Date: Thu, 11 Jul 2024 12:12:04 +0800
Subject: [PATCH] fix(user): prompt before sending lab rankings

---
 src/routes/dashboard/(draft)/ranks/+page.server.js     |  2 +-
 .../dashboard/(draft)/ranks/SubmitRankings.svelte      | 10 ++++++----
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/routes/dashboard/(draft)/ranks/+page.server.js b/src/routes/dashboard/(draft)/ranks/+page.server.js
index 36584e3..6c34b42 100644
--- a/src/routes/dashboard/(draft)/ranks/+page.server.js
+++ b/src/routes/dashboard/(draft)/ranks/+page.server.js
@@ -23,7 +23,7 @@ export const actions = {
 
         const maxRounds = await db.getMaxRoundInDraft(draft);
         if (maxRounds === null) error(404);
-        if (labs.length !== maxRounds) error(400);
+        if (labs.length > maxRounds) error(400);
 
         if (await db.insertStudentRanking(draft, user.email, labs)) return;
         return fail(403);
diff --git a/src/routes/dashboard/(draft)/ranks/SubmitRankings.svelte b/src/routes/dashboard/(draft)/ranks/SubmitRankings.svelte
index d7eb763..662824a 100644
--- a/src/routes/dashboard/(draft)/ranks/SubmitRankings.svelte
+++ b/src/routes/dashboard/(draft)/ranks/SubmitRankings.svelte
@@ -70,7 +70,11 @@
 <form
     method="post"
     class="space-y-4"
-    use:enhance={({ submitter }) => {
+    use:enhance={({ submitter, cancel }) => {
+        if (!confirm(`Are you sure you want to select ${selectedLabs.length} labs?`)) {
+            cancel();
+            return;
+        }
         assert(submitter !== null);
         assert(submitter instanceof HTMLButtonElement);
         submitter.disabled = true;
@@ -106,9 +110,7 @@
                 You may no longer select any more labs.
             {/if}
         </p>
-        <button type="submit" disabled={hasRemaining} class="variant-filled-primary btn disabled:!variant-ghost-primary"
-            >Submit Lab Preferences</button
-        >
+        <button type="submit" class="variant-filled-primary btn">Submit Lab Preferences</button>
     </div>
     <hr class="!border-surface-400-500-token !border-t-4" />
     {#each selectedLabs as { lab_id, lab_name }, idx (lab_id)}