Email Helper #3
Merged
Email Helper #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeeIsForVanana
force-pushed
the
email-overhaul
branch
from
4cc757e
to
ebefd13
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
BastiDood
requested changes
Jul 15, 2024
Co-authored-by: Basti Ortiz <39114273+BastiDood@users.noreply.github.com>
Co-authored-by: Basti Ortiz <39114273+BastiDood@users.noreply.github.com>
Co-authored-by: Basti Ortiz <39114273+BastiDood@users.noreply.github.com>
BastiDood
force-pushed
the
email-overhaul
branch
from
f28e166
to
efbef72
Compare
BastiDood
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
This can be merged for now, but future work involves removing nodemailer as a dependency and instead preferring the raw Gmail REST API for sending OAuth2-based emails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes the helper functions for sending emails on behalf of a designated admin. This includes setting up the
designated_senderschema identifying the designated sender, the CRUD operations on this schema, obtaining an authorized access token and refresh token, and refreshing the access token using the latter.