Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note in "Merging Data" #5

Open
bundfussr opened this issue Nov 24, 2022 · 2 comments
Open

Add note in "Merging Data" #5

bundfussr opened this issue Nov 24, 2022 · 2 comments
Assignees

Comments

@bundfussr
Copy link

I think a note in "Merging Data" regarding handling of variables which occur in both datasets would be helpful.
Assume both datasets adsl and adsl_weight have the variable STUDYID but STUDYID is not specified for by. In SAS STUDYID from adsl_weight overwrites the values of STUDYID from adsl and a note is issued. In R the output dataset will have variable STUDYID.x from adls and STUDYID.y from adsl_weight but it does not have STUDYID anymore. (The admiral function derive_vars_merged() checks this and issues an error if a variable occurs in both datasets and is not specified for by_vars.)

@iqis iqis assigned iqis, mattkumar and kaz462 and unassigned kaz462 Nov 28, 2022
@mattkumar
Copy link
Contributor

Thanks for the issue @bundfussr! I think this is a great note to add, that also goes hand-in-hand with other SAS-isms that have already been pointed out (@kaz462 and missing data)

Wondering if this is best covered in section 3.1.9 Merging Data or through a section devoted to admiral (e.g. future topics)? Open to all thoughts @bundfussr @kaz462

@bundfussr
Copy link
Author

@mattkumar , I think it's best to add it to 3.1.9 Merging Data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants