Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert MultiTypeSymbolTable from storing nilable objects to non-nilable #176

Closed
bradcray opened this issue Nov 1, 2019 · 1 comment
Closed
Labels
Chapel Needs attention from a member of the Chapel team enhancement New feature or request

Comments

@bradcray
Copy link
Contributor

bradcray commented Nov 1, 2019

This issue notes that the current symbol table stores SymEntry? entries when it seems as though it could/should store (non-nilable) SymEntry entries instead. We should convert to the non-nilable version to reduce the need for nil checks altogether. This can be done at present, but only by abusing the language as noted in chapel-lang/chapel#14367.

This issue also relates to #169 in that using a map seems like a nice replacement for the associative domain/array combo that's currently used, but likely runs into chapel-lang/chapel#14361.

For this reason, I'm marking this as being in the Chapel team's court for now.

@glitch
Copy link
Collaborator

glitch commented Nov 17, 2021

Issue cleanup: I'm going to close this one since the current code uses a Map with GenSymEntry (non-nillable) and we are expected to merge #786 which changes the map signature to AbstractSymEntry with a loose typing hierarchy.

@glitch glitch closed this as completed Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chapel Needs attention from a member of the Chapel team enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants