-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge Ian's code #12
Comments
@iwelland, what's the status of this? |
ping @iwelland |
Let me try to push it tomorrow |
Basic manual testsIt would be wonderful if we had proper tests #2 but for right now, make sure that your code works by performing a manual test. For a start, see that you can run through the basic testing workflow (used to be #11 (comment)). Merge the latest development code into yoursIf your current code lives on the develop branch, make a new branch for right now:
Then merge the current develop:
If there are conflicts, fix all of them carefully. Install
Run the manual tests again. Create a PRInstead of pushing directly to develop, make a pull request. First push your work to origin/issue-12-iwelland:
Then go to the GitHub hop page and inititate a PR against the develop branch. See
Then assign the PR to @orbeckst and we will start discussing it. If anything is unclear just ask in this issue. |
Hi, I've tried to setup MDAnalysis 0.15 repeatedly (before tonight) and pip yields: Could not find a version that satisfies the requirement MDAnalysis>0.15.0 (from Hop==0.3.5) (from versions: 0.7.6, 0.8.0rc2, 0.8.0rc4, 0.8.0, 0.8.1rc1, 0.8.1, 0.9.0.dev0, 0.9.0, 0.9.1, 0.9.2, 0.10.0, 0.11.0, 0.12.1, 0.13.0, 0.14.0, 0.15.0) Any idea why? |
The problem is stated in the output:
The |
Oops, sorry, my fault. I just fixed it.
|
@iwelland has done major additions, which need to be merged
The text was updated successfully, but these errors were encountered: