Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Transposition function #13

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Conversation

catkins
Copy link

@catkins catkins commented Sep 26, 2021

Fixes #12

  • Adds new TRANSPOSE sub-menu to FUNCTION menu on analogue inputs
    • Adds transposition plus or minus 10 octaves and 12 semitones.

@catkins
Copy link
Author

catkins commented Sep 26, 2021

I've tested this on a CV thing, but not on a VCMC (as I don't have one), and seems to work as expected.

One small issue I need to figure out that is that occasionally I needed to panic the midi after changing the octave/semitone value. The NoteOff messages may not taking into account the transposition if I've got a sequence running whilst I change the parameter so I'll need to poke around to suss that out.

I'm still finding my way around the codebase, but I assume that will be a fairly easy fix.

@catkins
Copy link
Author

catkins commented Oct 14, 2021

Haven't seen the note sticking thing again.

@xustafu @SergioRetamero - are you able to review this PR when you get a moment?

@xustafu
Copy link
Collaborator

xustafu commented Oct 16, 2021

Sorry for the delayed answer!!! hope to be testing this one on monday. In the meantime, and for organization purposes, do you mind doing the request to be merged to Transpose branch?

@catkins catkins changed the base branch from master to Transpose October 17, 2021 08:59
@catkins
Copy link
Author

catkins commented Oct 17, 2021

Awesome, thanks @xustafu

Updated the base to be the Transpose branch on origin.

Let me know how you go 😁

@xustafu xustafu merged commit 2c47ff1 into Befaco:Transpose Oct 26, 2021
@catkins catkins deleted the transpose-menu branch October 27, 2021 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: V/Oct transpose
2 participants