Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overlapping cards and header refactor #220

Merged
merged 1 commit into from
Oct 25, 2023
Merged

overlapping cards and header refactor #220

merged 1 commit into from
Oct 25, 2023

Conversation

VaibhavGagneja
Copy link
Contributor

@VaibhavGagneja VaibhavGagneja commented Oct 21, 2023 •
edited
Loading

Issue Addressed

#218 Fixed overlapping cards and header empty space for mobile mode

Proposed Changes and Benefits

Screenshots

Header Refactor
image
Overlapping Cards fix
image
image

Notes to Reviewers

@XanderRubio Check if this seems good thankyou

Checklist

  • I have thoroughly read and understand The Contribution Guidelines.
  • The title of this PR follows the keyword: brief description of change format, using one of the following keywords:
    • Feature - adds new or amends existing user-facing behavior.
    • Chore - changes that have no user-facing value, refactors, dependency bumps, etc.
    • Fix - bug fixes.
    • Docs - fixing typos and adding new content.
  • I have listed my proposed changes and their benefits.
  • I have linked the corresponding issue in the Issues section.

@vercel
Copy link

vercel bot commented Oct 21, 2023

@VaibhavGagneja is attempting to deploy a commit to the Before I Die Code Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
before-i-die-achievements ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 7:05am

XanderRubio
XanderRubio approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@XanderRubio XanderRubio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @VaibhavGagneja,

Everything makes sense for what you have done, and, additionally, it shows up much more pleasing from a UI perspective when viewing the preview deployment. Great work, and I am going ahead with merging now!

@XanderRubio XanderRubio merged commit a01b064 into BeforeIDieCode:main Oct 25, 2023
2 checks passed
@XanderRubio XanderRubio linked an issue Oct 25, 2023 that may be closed by this pull request
[BUG] Overlapping Cards #218
Open
3 tasks
@XanderRubio
Copy link
Member

Congratulations @VaibhavGagneja, for having your PR merged, and thank you for closing out issue #218 with your contribution! Great work, and have a nice day!

@VaibhavGagneja
Copy link
Contributor Author

Congratulations @VaibhavGagneja, for having your PR merged, and thank you for closing out issue #218 with your contribution! Great work, and have a nice day!

Thanks a lot can you pls reassign hacktoberfest accepted and hacktoberfest label if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XanderRubio XanderRubio XanderRubio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Overlapping Cards
2 participants
@VaibhavGagneja @XanderRubio