From 0373b6cfde962f729a6ee0167a4bc9a60ab0964b Mon Sep 17 00:00:00 2001 From: Kukhyeon Heo Date: Thu, 9 Jun 2022 00:40:58 +0900 Subject: [PATCH] fix: Remove period in "learn more." button (#21935) Co-authored-by: Matt Henkes --- packages/frontend-shared/src/locales/en-US.json | 1 + packages/launchpad/cypress/e2e/project-setup.cy.ts | 2 +- packages/launchpad/src/components/code/FileRow.vue | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/frontend-shared/src/locales/en-US.json b/packages/frontend-shared/src/locales/en-US.json index 4ed10ca378f2..f7f0ddbae78d 100644 --- a/packages/frontend-shared/src/locales/en-US.json +++ b/packages/frontend-shared/src/locales/en-US.json @@ -1,6 +1,7 @@ { "links": { "learnMore": "Learn more.", + "learnMoreButton": "Learn more", "needHelp": "Need help" }, "components": { diff --git a/packages/launchpad/cypress/e2e/project-setup.cy.ts b/packages/launchpad/cypress/e2e/project-setup.cy.ts index a98ba2adae1c..d5a112ed4704 100644 --- a/packages/launchpad/cypress/e2e/project-setup.cy.ts +++ b/packages/launchpad/cypress/e2e/project-setup.cy.ts @@ -623,7 +623,7 @@ describe('Launchpad: Setup Project', () => { cy.findByRole('button', { name: 'Skip' }).click() cy.intercept('POST', 'mutation-ExternalLink_OpenExternal', { 'data': { 'openExternal': true } }).as('OpenExternal') - cy.findByText('Learn more.').click() + cy.findByText('Learn more').click() cy.wait('@OpenExternal') .its('request.body.variables.url') .should('equal', 'https://on.cypress.io/guides/configuration') diff --git a/packages/launchpad/src/components/code/FileRow.vue b/packages/launchpad/src/components/code/FileRow.vue index 09c833b4c12f..e77c61a773b2 100644 --- a/packages/launchpad/src/components/code/FileRow.vue +++ b/packages/launchpad/src/components/code/FileRow.vue @@ -46,7 +46,7 @@ class="whitespace-nowrap" href="https://on.cypress.io/guides/configuration" > - {{ t('links.learnMore') }} + {{ t('links.learnMoreButton') }}