You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Nice work, found minor thing: when first image clicked, left arrow is shown wrongly as updateArrowActivation() is not being called. Suggest replace updateArrowActivation() with two getters like:
public get left(): boolean {
return this.currentIdx > 0;
}
public get right(): boolean {
return this.currentIdx < this.images.length - 1;
}
Nice work, found minor thing: when first image clicked, left arrow is shown wrongly as updateArrowActivation() is not being called. Suggest replace updateArrowActivation() with two getters like:
public get left(): boolean {
return this.currentIdx > 0;
}
public get right(): boolean {
return this.currentIdx < this.images.length - 1;
}
Then in template:
<img [ngClass]="{'activeArrow': left}" ... />
<img [ngClass]="{'activeArrow': right}" ... />
The text was updated successfully, but these errors were encountered: