Exploit additional concurrency in the training algorithm #105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches two
do
loops in the training algorithm todo concurrent
constructs. Inspection of the code indicates that there are no values defined in one iteration that are accessed in a subsequent iteration. This conclusion was also tested by temporarily changing the stride of each affecteddo
loops from the default (1
) to-1
in order to reverse the order of the iterations. With a stride of-1
, all tests pass andapp/train-cloud-microphysics.f90
yields the same convergence behavior as with a stride of1
when run as follows using a training data set from ICAR.