Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new fpm subproject icar-trainer #108

Merged
merged 13 commits into from
Jan 17, 2024
Merged

Add new fpm subproject icar-trainer #108

merged 13 commits into from
Jan 17, 2024

Conversation

ktras
Copy link
Collaborator

@ktras ktras commented Jan 6, 2024 •
edited
Loading

Add new fpm subproject, icar-trainer, which removes dependencies from inference-engine.

@ktras
feat(fpm): Add new fpm subproject, icar-trainer
6493423 
Add new fpm subproject, icar-trainer, which removes dependencies
from inference-engine. This commit contains a working solution
for an fpm build of inference-engine. The icar-trainer fpm toml
file and associated setup script are not yet complete, and need
to be edited to be buildable.
@ktras
Rename new subdir to cloud-microphysics
874d21f
@ktras
(fix): Update cloud-microphysics fpm.toml and setup script to build
2a12de7 
using the previous strategy (generating a build/run-fpm.sh script
that is necessary to use) but in this new subdir structure.
@rouson
Copy link
Contributor

rouson commented Jan 12, 2024

@ktras I'm getting a seg fault with the trailing output below when I run cloud-microphysics/setup.sh. Presumably that's why this is a Draft PR. Let me know when it's ready for review.

icar-trainer-test                      done.
[100%] Project compiled successfully.
 
A NetCDF_file_t object
icar-trainer-test(61588,0x1d814dec0) malloc: *** error for object 0x726f727265206f4e: pointer being freed was not allocated
icar-trainer-test(61588,0x1d814dec0) malloc: *** set a breakpoint in malloc_error_break to debug

Program received signal SIGABRT: Process abort signal.

Backtrace for this error:
#0  0x102c17537
#1  0x102c16513
#2  0x181fcba23
#3  0x181f9ccbf
#4  0x181eaca3f
#5  0x181dc3b07
#6  0x181dc73f3
#7  0x181ddbebb
#8  0x102084c7f
#9  0x102090317
#10  0x102084467
#11  0x10216f55f
<ERROR> Execution for object " icar-trainer-test " returned exit code  6
<ERROR> *cmd_run*:stopping due to failed executions
STOP 6

@ktras
Copy link
Collaborator Author

ktras commented Jan 12, 2024

@rouson Thanks for letting me know. I do not get that segfault though. Can you tell me what compiler and version you are using?

@ktras ktras marked this pull request as ready for review January 12, 2024 23:41
rouson
rouson reviewed Jan 12, 2024
View reviewed changes
setup.sh Outdated Show resolved Hide resolved
@rouson
Copy link
Contributor

rouson commented Jan 12, 2024

In another branch, I'll edit the README.md to indicate that gfortran 13 is the minimum requirement (because gfortran 12 seg faults).

rouson
rouson reviewed Jan 13, 2024
View reviewed changes
Copy link
Contributor

@rouson rouson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ktras I made a few more comments

cloud-microphysics/test/main.f90 Outdated Show resolved Hide resolved
cloud-microphysics/test/main.f90 Outdated Show resolved Hide resolved
cloud-microphysics/scripts/run-fpm.sh-header Outdated Show resolved Hide resolved
rouson
rouson reviewed Jan 16, 2024
View reviewed changes
setup.sh Outdated Show resolved Hide resolved
@ktras ktras requested a review from rouson January 17, 2024 02:40
ktras and others added 2 commits January 16, 2024 18:43
@ktras @rouson
Update cloud-microphysics/test/main.f90
4f39ebb 
Co-authored-by: Damian Rouson <rouson@lbl.gov>
@ktras @rouson
Update cloud-microphysics/test/main.f90
9413172 
Co-authored-by: Damian Rouson <rouson@lbl.gov>
rouson
rouson approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@rouson rouson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cloud-microphysics/test/main.f90 Show resolved Hide resolved
cloud-microphysics/test/main.f90 Outdated Show resolved Hide resolved
setup.sh Outdated Show resolved Hide resolved
setup.sh Outdated Show resolved Hide resolved
setup.sh Outdated Show resolved Hide resolved
setup.sh Outdated Show resolved Hide resolved
setup.sh Show resolved Hide resolved
cloud-microphysics/setup.sh Outdated Show resolved Hide resolved
ktras and others added 4 commits January 17, 2024 11:22
@ktras @rouson
Update setup.sh
38000a9 
Co-authored-by: Damian Rouson <rouson@lbl.gov>
@ktras
fix: Remove now redundant clause about gfortran at beginning of
62bf5b4 
top level dir setup script.
@ktras @rouson
Update cloud-microphysics/test/main.f90
da229d8 
Co-authored-by: Damian Rouson <rouson@lbl.gov>
@ktras @rouson
Update cloud-microphysics/test/main.f90
9f2829a 
Co-authored-by: Damian Rouson <rouson@lbl.gov>
This was referenced Jan 17, 2024
Closed
Closed
@ktras @rouson
Update setup.sh
7847e32 
Co-authored-by: Damian Rouson <rouson@lbl.gov>
@ktras ktras merged commit a173c71 into main Jan 17, 2024
4 checks passed
@ktras ktras deleted the create-icar-trainer-subdir branch January 17, 2024 22:22
@rouson
Copy link
Contributor

rouson commented Jul 13, 2024

@ktras I think this has been completed and merged into main so I'm closing this issue. Feel free to reopen it if you think it's still an unresolved issue.

@rouson
Copy link
Contributor

rouson commented Jul 13, 2024

@ktras oops... this was already closed. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rouson rouson rouson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktras @rouson