Refactor: remove legacy component arrays in inference_engine_t
#67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove legacy array references from assert_conformable subroutine.
By moving the construct_from_legacy_arrays function interface body to the inference_engine_s submodule, this commit removes any mention of the legacy inference_engine_t component arrays from the public interface defined in the inference_engine_m module. The legacy component arrays themselves were removed in an earlier commit so they exist only as dummy arguments in the aforementioned function. Those dummy arguments get assigned to the appropriate sections of the current interface_engine_t component arrays.
This commit 1. Adds metadata component to trainable_engine_t matching the like-named component inside inference_engine_t and 2. Adds a to_inference_engine convertor type-bound procedure to trainable_engine_t.
also reduce to a single hidden layer with two nodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Do
construct_from_jsonsubroutine ininference_engine_s.f90)Testing with a random-weight/bias network with
n = [2, 3, 2]input-, output-, and hidden-layer nodes yields one test failure:due to a difference in one hidden-layer weight. Switching to
n = [2, 3, 1]eliminates the input/output file difference but still causes a test failure.