feat: added options object with parse option #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributors |
Berkmann18
changed the title
Berkmann18
approved these changes
Oct 22, 2019
index.js
Outdated
| optionsCopy.parse = true; | ||
| } | ||
|
|
||
| console.log("opt", optionsCopy) |
There was a problem hiding this comment.
Wouldn't this be something to print if options.verbose = true or was that just to test and not meant to stay there?
There was a problem hiding this comment.
I forgot this during debugging ... I'll fix it.
index.js
Outdated
| * @param {boolean} [verbose=false] Verbosity | ||
| * @returns {{data: (Object|string|Array), changed: boolean}} Result | ||
| */ | ||
| const checkJson = (data, verbose = false) => { | ||
| const checkJson = (data, options, verbose = false) => { |
There was a problem hiding this comment.
As options is there, do you think it would make more sense in merging verbose into it (ie. it will be a key in options like parse)?
That way, checkJson doesn't need an extraneous 3rd argument which could simply be specified in the second one (e.g. checkJson(..., {parse: ..., verbose: ...}).
Also, thank you for your contribution 😁.
Berkmann18
added
Priority: High
Status: Waiting for Feedback
Type: Enhancement 💡
|
@all-contributors Please add @SvetozarMateev for code |
|
I've put up a pull request to add @SvetozarMateev! 🎉 |
Berkmann18
pushed a commit
that referenced
this pull request
Dec 15, 2019
# [1.4.0](v1.3.2...v1.4.0) (2019-12-15) ### Bug Fixes * **fixer:** improved trailing character fixer ([d671f0c](d671f0c)), closes [#18](#18) * **package-lock:** vulnerability fix ([a61b48a](a61b48a)) * **security:** bumped outdated packages + fixed vulnerabilities ([78bf487](78bf487)) ### Features * added options object with parse option ([#21](#21)) ([22874df](22874df))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR implements:
Details
What does this PR implements exactly?
This is a feature that I think would be useful because there is no other library that can fix a string to be a valid JSON and with the options object and the parse property that will be possible.