Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calva Refactor commands not appearing in command palette after initial start #1610

Closed
bpringe opened this issue Mar 21, 2022 · 5 comments
Closed
Labels
bug Something isn't working lsp regression Regression error

Comments

@bpringe
Copy link
Member

bpringe commented Mar 21, 2022

In 2.0.256 the Calva Refactor commands don't show up in the command palette (I'm not sure if they're being registered), even after clojure-lsp has started. In 2.0.255, they do show up. CC @PEZ

@bpringe bpringe added bug Something isn't working lsp regression Regression error labels Mar 21, 2022
@bpringe
Copy link
Member Author

bpringe commented Mar 21, 2022

I witnessed this in two different projects, but now it seems to work with 2.0.256... I restarted clojure-lsp in one project in which it wasn't working (even though I had recently just opened the project recently to test it - so clojure-lsp hadn't been running long), and it started working. 🤔

@bpringe
Copy link
Member Author

bpringe commented Mar 21, 2022

I'll close this for now... but we should keep an eye out for this.

@bpringe bpringe closed this as completed Mar 21, 2022
@bpringe bpringe reopened this Mar 21, 2022
@bpringe
Copy link
Member Author

bpringe commented Mar 21, 2022

Okay, this appears to be an issue on initial loading of a project (the first time clojure-lsp starts up, automatically).

@ieugen
Copy link
Contributor

ieugen commented Mar 21, 2022

I've also noticed this issue and the one with Jack in not displaying 'choose alias' pop-up (link above)

@PEZ
Copy link
Collaborator

PEZ commented Mar 22, 2022

Okay, this appears to be an issue on initial loading of a project (the first time clojure-lsp starts up, automatically).

I did some shuffling around of how this happens in #1592 , because we can't register them twice. Seems it's now zero registers for the initial start...

@bpringe bpringe changed the title Calva Refactor commands not appearing in command palette Calva Refactor commands not appearing in command palette on initial start Mar 23, 2022
@bpringe bpringe changed the title Calva Refactor commands not appearing in command palette on initial start Calva Refactor commands not appearing in command palette after initial start Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lsp regression Regression error
Projects
None yet
Development

No branches or pull requests

3 participants