Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require VS Code 1.66+ (and update project node version to 16+) #1638

Closed
2 tasks
riotrah opened this issue Mar 27, 2022 · 1 comment · Fixed by #1661
Closed
2 tasks

Require VS Code 1.66+ (and update project node version to 16+) #1638

riotrah opened this issue Mar 27, 2022 · 1 comment · Fixed by #1661
Labels
dev housekeeping

Comments

@riotrah
Copy link
Member

riotrah commented Mar 27, 2022 •
edited
Loading

  • Upgrade the project's minimum node version to something at least more recent than v7.
  • Upgrade the typings accordingly.
@riotrah riotrah changed the title Update project node version Dev: Update project node version Apr 2, 2022
@rayat-amperity rayat-amperity mentioned this issue Apr 2, 2022
Merged
17 tasks
@riotrah
Copy link
Member Author

riotrah commented Apr 2, 2022 •
edited
Loading

Update:

  • Set minimum node to 16 (LTS)
  • Ensure node engine version uses ">=" instead of "^" in packagejson
  • Update node typings as well
  • Update .node-version file
  • Mandate vscode 1.66+

@riotrah riotrah changed the title Dev: Update project node version Dev: Update project node version to 16 Apr 2, 2022
@riotrah riotrah mentioned this issue Apr 2, 2022
Merged
17 tasks
@PEZ PEZ changed the title Dev: Update project node version to 16 Update project node version to 16 and require vscode 1.66+ Apr 3, 2022
@PEZ PEZ changed the title Update project node version to 16 and require vscode 1.66+ Requirere VS Code 1.66+ (and update project node version to 16+) Apr 3, 2022
@PEZ PEZ changed the title Requirere VS Code 1.66+ (and update project node version to 16+) Require VS Code 1.66+ (and update project node version to 16+) Apr 3, 2022
@riotrah riotrah linked a pull request Apr 7, 2022 that will close this issue
Upgrade to node v16 #1661
Merged
17 tasks
@riotrah riotrah closed this as completed Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev housekeeping
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to node v16 rayat-amperity/calva
2 participants
@PEZ @riotrah