Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default clojure-lsp startup behaviour is changed since v2.0.327 #2084

Closed
PEZ opened this issue Feb 16, 2023 · 0 comments
Closed

Default clojure-lsp startup behaviour is changed since v2.0.327 #2084

PEZ opened this issue Feb 16, 2023 · 0 comments
Labels
bug Something isn't working lsp regression Regression error

Comments

@PEZ
Copy link
Collaborator

PEZ commented Feb 16, 2023

The default clojure-lsp startup mistakingly changed with our added support for running multiple clojure-lsp servers. We need to restore this to it's old default and optionally provide configuration for the current start-up behaviour for workspaces that would benefit from it. (Though, most often workspaces benefit better from configuring them to be served by just one clojure-lsp server.)

The change can have quite serious implications. In a workspace I have, there are lots of clojure-lsp servers spawning when I open it in VS Code. Even with the smarter startup introduced with #2075 and #2076 we still spawn about 30 servers in this workspace. Looks like so:

image

@PEZ PEZ added bug Something isn't working regression Regression error lsp labels Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lsp regression Regression error
Projects
None yet
Development

No branches or pull requests

1 participant