Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connecting to an external REPL does not work when local nrepl port exists #2303

Closed
punit-naik opened this issue Aug 30, 2023 · 4 comments
Closed
Labels
bug Something isn't working connect

Comments

@punit-naik
Copy link
Contributor

If the .nrepl-port file is populated, while connecting to an external REPL, the prompt to pass external REPL's port does not pop up and calva directly connects to the nREPL port from the .nrepl-port file.

Steps to reproduce:

  1. Populate the .nrepl-port file with some random port
  2. Try connecting to an external REPL
@bpringe bpringe added the connect label Sep 1, 2023
@bpringe
Copy link
Member

bpringe commented Sep 1, 2023

@PEZ What's the expected behavior in this case?

Also, I noticed I don't see that file mentioned in the docs. Should we add some info about it there?

@PEZ
Copy link
Collaborator

PEZ commented Sep 1, 2023

The expected behaviour is that Calva should ask for the nrepl port. We could pre-populate with the port number from .nrepl-port, maybe, but at least the user needs a way to change the port number. Most often the port file is written by some unrelated nREPL server.

I guess that where we talk about standalone connect we could mention that Calva looks for port files (based on connect sequence) and pre-populates the connect prompt.

@bpringe
Copy link
Member

bpringe commented Sep 3, 2023

The expected behaviour is that Calva should ask for the nrepl port.

So this is a bug? I'll mark it as such, but remove the tag if I'm wrong.

@bpringe bpringe added the bug Something isn't working label Sep 3, 2023
@PEZ
Copy link
Collaborator

PEZ commented Sep 3, 2023

Yeah, we can call it a bug. 😄 It's an unhandled special case.

@PEZ PEZ changed the title Connecting to an external REPL does not work Connecting to an external REPL does not work when local nrepl port exists Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working connect
Projects
None yet
Development

No branches or pull requests

3 participants