-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clj-kondo was not found in the classpath #639
Comments
What kind of project is it? shadow-cljs? |
yup. shadow-cljs |
Chipping is just to say I'm having the same issue. About my runtime environment: {
"name": "Clojurescript Development",
"image": "clojure:openjdk-14-tools-deps-alpine",
"forwardPorts": [8700, 8777, 9630],
"settings": {
"terminal.integrated.shell.linux": "/bin/ash"
},
"postCreateCommand": "apk update && apk add git openssh npm && npm i",
"extensions": ["betterthantomorrow.calva"]
} |
This is message was added in the recent debugger decorations feature. If you're not using Calva's jack-in, and you're connecting to a REPL without clj-kondo loaded as a dependency, you will get that warning. @PEZ I think we need to document that dependency in the debug docs and maybe elsewhere, so that if someone wants the feature but is not using jack-in, they know how to load the dep. But also, do you think we should remove the warning message? I initially added it so that users would know why a feature they may try to use does not work, but it seems it may cause unnecessary concern. We could also make the warning only show up if they try to use the feature it pertains to, meaning the instrument command - but we'd want to make sure it only happens the first time in a given run of Calva. But if they frequently use Calva without clj-kondo for whatever reasons, this warning would likely get annoying still. |
@bpringe I've been connecting using jack-in though but I guess I can check if clj-kondo is in the dependencies |
@jorda0mega That's interesting, there could be an issue there. The calva jack-in command adds clj-kondo as a dependency, so it should be there. When I run jack-in I see
in my terminal. Do you see clj-kondo in your terminal when you jack-in too? If you do and then you still get that warning, something weird is going on. If you can provide a repro project that might help. |
I am seeing this issue as well, perhaps they are related? |
@bpringe the project is https://github.com/athensresearch/athens. I realize the project is actually lein + shadow-cljs. However, if I try to jack-in with lein + shadow-cljs it just hangs. I am able to start up the local server by jack-in with just shadow-cljs but then I get the clj-kondo warning |
@jorda0mega When I try to jack-in to that project with lein + shadoiw-cljs I do see it hanging like you say, and I also see the error from the issue @winterscar linked to in the Tasks output, so I think that is related to that issue. We'll need to follow up on that separately. I have a fix coming that will remove this warning as a window message and also fixes a sort of related issue. |
v2.0.100 is out now and should remove this window warning. Thanks for the feedback! |
that did it. thanks so much for looking into this! |
No problem! Thanks for assisting with making Calva better! |
getting the following error when starting a REPL connection to the project. any ideas on how to fix?
The text was updated successfully, but these errors were encountered: