Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clj-kondo was not found in the classpath #639

Closed
jorda0mega opened this issue May 7, 2020 · 12 comments
Closed

clj-kondo was not found in the classpath #639

jorda0mega opened this issue May 7, 2020 · 12 comments
Labels

Comments

@jorda0mega
Copy link

getting the following error when starting a REPL connection to the project. any ideas on how to fix?

image

@PEZ
Copy link
Collaborator

PEZ commented May 7, 2020

What kind of project is it? shadow-cljs?

@jorda0mega
Copy link
Author

jorda0mega commented May 7, 2020

yup. shadow-cljs

@winterscar
Copy link

Chipping is just to say I'm having the same issue. About my runtime environment:
OS: Windows 10
VS Code: Latest
Calva: Latest
Remote development: docker container
devcontainer.json:

{
	"name": "Clojurescript Development",
	"image": "clojure:openjdk-14-tools-deps-alpine",
	"forwardPorts": [8700, 8777, 9630],
	"settings": { 
		"terminal.integrated.shell.linux": "/bin/ash"
  },
	"postCreateCommand": "apk update && apk add git openssh npm && npm i",
	"extensions": ["betterthantomorrow.calva"]
}

@bpringe
Copy link
Member

bpringe commented May 11, 2020

This is message was added in the recent debugger decorations feature. If you're not using Calva's jack-in, and you're connecting to a REPL without clj-kondo loaded as a dependency, you will get that warning.

@PEZ I think we need to document that dependency in the debug docs and maybe elsewhere, so that if someone wants the feature but is not using jack-in, they know how to load the dep. But also, do you think we should remove the warning message? I initially added it so that users would know why a feature they may try to use does not work, but it seems it may cause unnecessary concern.

We could also make the warning only show up if they try to use the feature it pertains to, meaning the instrument command - but we'd want to make sure it only happens the first time in a given run of Calva. But if they frequently use Calva without clj-kondo for whatever reasons, this warning would likely get annoying still.

@jorda0mega
Copy link
Author

@bpringe I've been connecting using jack-in though but I guess I can check if clj-kondo is in the dependencies

@bpringe
Copy link
Member

bpringe commented May 11, 2020

@jorda0mega That's interesting, there could be an issue there. The calva jack-in command adds clj-kondo as a dependency, so it should be there. When I run jack-in I see

> Executing task: clojure -Sdeps '{:deps {nrepl {:mvn/version "0.6.0"} cider/cider-nrepl {:mvn/version "0.23.0"} clj-kondo {:mvn/version "2020.04.05"}}}'  -m nrepl.cmdline --middleware "[cider.nrepl/cider-middleware]" <

in my terminal. Do you see clj-kondo in your terminal when you jack-in too? If you do and then you still get that warning, something weird is going on. If you can provide a repro project that might help.

@winterscar
Copy link

I am seeing this issue as well, perhaps they are related?

@jorda0mega
Copy link
Author

@bpringe the project is https://github.com/athensresearch/athens. I realize the project is actually lein + shadow-cljs. However, if I try to jack-in with lein + shadow-cljs it just hangs.

image

I am able to start up the local server by jack-in with just shadow-cljs but then I get the clj-kondo warning

@bpringe bpringe mentioned this issue May 11, 2020
20 tasks
@bpringe
Copy link
Member

bpringe commented May 11, 2020

@jorda0mega When I try to jack-in to that project with lein + shadoiw-cljs I do see it hanging like you say, and I also see the error from the issue @winterscar linked to in the Tasks output, so I think that is related to that issue. We'll need to follow up on that separately. I have a fix coming that will remove this warning as a window message and also fixes a sort of related issue.

@bpringe
Copy link
Member

bpringe commented May 11, 2020

v2.0.100 is out now and should remove this window warning. Thanks for the feedback!

@bpringe bpringe closed this as completed May 11, 2020
@jorda0mega
Copy link
Author

that did it. thanks so much for looking into this!

@bpringe
Copy link
Member

bpringe commented May 11, 2020

No problem! Thanks for assisting with making Calva better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants