Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cider-nrepl version used by Calva #852

Closed
bpringe opened this issue Nov 26, 2020 · 5 comments
Closed

Upgrade cider-nrepl version used by Calva #852

bpringe opened this issue Nov 26, 2020 · 5 comments
Assignees

Comments

@bpringe
Copy link
Member

bpringe commented Nov 26, 2020

#427 (comment)

https://github.com/clojure-emacs/cider-nrepl/blob/master/CHANGELOG.md

At the time of this writing Calva is using 0.23.0.

@bbatsov
Copy link
Contributor

bbatsov commented Nov 30, 2020

That should be pretty straightforward as most of the changes have been bug-fixes.

@bpringe bpringe self-assigned this Nov 30, 2020
@bbatsov
Copy link
Contributor

bbatsov commented Dec 22, 2020

Btw, does Calva have some functionality related to ClojureDocs? I'm asking as I've noticed that the data usage for https://clojuredocs-edn.netlify.app/ has been growing this month and I'm wondering why. An unfortunate design decision in older version of cider-nrepl resulted in constant downloads of fresh exports on start, so I'm assuming Calva's growing usage might be related to this.

@PEZ
Copy link
Collaborator

PEZ commented Dec 22, 2020

Those features are lacking in Calva still. We should add it. But first bump cider-nrepl, I take it?

@bbatsov
Copy link
Contributor

bbatsov commented Dec 22, 2020

Ideally - yes.

@PEZ
Copy link
Collaborator

PEZ commented Jan 7, 2021

I keep forgetting to add the proper issues to my fixes notes. Anyway, this is now done.

@PEZ PEZ closed this as completed Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants