Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vanilla cljfmt for regular formatting #1179

Closed
bpringe opened this issue May 12, 2021 · 3 comments
Closed

Use vanilla cljfmt for regular formatting #1179

bpringe opened this issue May 12, 2021 · 3 comments
Labels
formatting

Comments

@bpringe
Copy link
Member

bpringe commented May 12, 2021

Formatting of code with namespaced keywords does not work (or does not work well?) currently. @PEZ suggested updating our fork of cljfmt would fix the issue.
@PEZ
Copy link
Collaborator

PEZ commented May 18, 2021

I did some work on it a month ago or so, actually: https://github.com/BetterThanTomorrow/cljfmt/tree/pez/align-pairs

Things have moved a lot under our feet here, much thanks to @lread. I could almost get it to work, but the align code misbehaves like crazy. I'm thinking that maybe we should solve the aligniment som other way and use vanilla cljfmt for the regular formatting...

@PEZ
Copy link
Collaborator

PEZ commented May 18, 2021

I of course mean that it is super duper great that things have moved, in case that wasn't all that clear. 😄

@bpringe
Copy link
Member Author

bpringe commented May 19, 2021

I'm thinking that maybe we should solve the aligniment som other way and use vanilla cljfmt for the regular formatting...

This seems to be a good idea to me.

@bpringe bpringe changed the title Update our fork of cljfmt Use vanilla cljfmt for regular formatting Aug 22, 2021
@bpringe bpringe mentioned this issue Aug 22, 2021
Closed
@bpringe bpringe mentioned this issue Nov 13, 2021
Closed
@bpringe bpringe mentioned this issue Dec 2, 2021
Closed
PEZ added a commit that referenced this issue Feb 12, 2022
@PEZ
Use vanilla cljfmt instead of pez-cljfmt default
fbf1008 
Also inline pez-cljfmt and use it if :align-associative? is true

Fixes #1179
Fixes #1414
Fixes #1267
Fixes #1054
Fixes #870
Fixes #807
Fixes #782
@PEZ PEZ mentioned this issue Feb 12, 2022
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
formatting
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PEZ @bpringe