Add host authorization config for sinatra 4.1 #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was actually just debugging this locally on friday. I need to find a way to get dependabot to pick up the gemfiles/*
|
|
also, fun story, but i believe rails <7.1 is incompatible with sinatra >=4.1 |
|
okay, i'm going to land this one and then fix the builds which should technically be broken for this version of sinatra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sinatra 4.1.0 adds a new default config for permitted hosts (sinatra/sinatra#2053). In the development environment, the permitted hosts are IP addresses,
.localhost, and.test. This is causing failures in webvalve because webvalve passes through the original request, including the host of the faked service.FWIW, I think this didn't get picked up by CI because #81 updated Gemfile.lock in the root directory, but it looks like CI runs against the Gemfiles in
gemfiles/*which didn't get updated (so are still running against sinatra 4.0).