fix: appraisals are out of date for sinatra upgrade

[samandmoore]

cc @aburgel

this was failing until i rebased on your fixes from #82

/no-platform

[samandmoore]

oh fun, ruby version x gem version sadness. looking at it.

[rzane]

We should probably drop this version.

[rzane]

domain lgtm
platform lgtm

[aburgel]

Are you supposed to commit the lock files for the appraisal gemfiles? (https://github.com/thoughtbot/appraisal?tab=readme-ov-file#version-control)

Without the lock files, then you'd at least get the latest matching version of whatever gem to test against. If you couple that with a test run against the root Gemfile.lock, then you'd also get test coverage over whatever dependabot is updating to.

[samandmoore]

this branch is getting wrecked by some gem incompatibility between ruby < 3.2 and zeitwerk of a certain vintage.

i have to figure out the right combination of gemfile settings + github actions matrix settings to get this humming.

todo:

• drop ruby 3.0 (eol)
• drop ruby 3.1 (security maintainence)
• add ruby 3.3

^ this should make the zeitwerk thing moot

then we should also

• add rails 7.1
• add rails 8.0

[samandmoore]

also, my local system just hosed itself while i was working through this 😮‍💨

so i've gotta figure that out before i can actually get back to fixing this for realz.

[samandmoore]

Are you supposed to commit the lock files for the appraisal gemfiles? (https://github.com/thoughtbot/appraisal?tab=readme-ov-file#version-control)

Without the lock files, then you'd at least get the latest matching version of whatever gem to test against. If you couple that with a test run against the root Gemfile.lock, then you'd also get test coverage over whatever dependabot is updating to.

i'm gonna look into that separately. i've truly never found a super satisfying approach. doing what you suggest would be even more useful if we ran the build on a cron too

[rzane]

domain lgtm