Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Probably need to expose CSSParsingException in new api #223

Open
folkyatina opened this issue Jun 26, 2021 · 1 comment
Open

Probably need to expose CSSParsingException in new api #223

folkyatina opened this issue Jun 26, 2021 · 1 comment
Labels
feature request
Milestone
1.5

Comments

@folkyatina
Copy link
Contributor

In PR #219 we have added explicit method to parse CSS. But it does not expose any error while parsing CSS.

We probably should throw CSSParseException from CSS#getFromString() to allow users to react properly if there is a problem with css.
@BigBadaboom
Copy link
Owner

Agreed.

@BigBadaboom BigBadaboom added this to the 1.5 milestone Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
1.5
Development

No branches or pull requests
2 participants
@BigBadaboom @folkyatina