Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CIP-0129 support to governance action id objects #89

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

AngelCastilloB
Copy link
Member

Description

Added CIP-0129 factory method to Governance Id Actions

Checklist

  • I have read followed CONTRIBUTING.md
    • I have added tests
    • I have updated the documentation
    • I have updated the CHANGELOG
  • Are there any breaking changes?
    • If yes: I have marked them in the CHANGELOG
  • Does this PR introduce any platform specific code?
  • Security: Does this PR potentially affect security?
  • Performance: Does this PR potentially affect performance?

@AngelCastilloB AngelCastilloB force-pushed the feat/add-cip129-support-to-gov-action branch 2 times, most recently from ba5f40f to 234adb1 Compare December 3, 2024 12:57
Copy link

github-actions bot commented Dec 3, 2024

MISRA C Logo

MISRA Guideline Compliance Summary

Commit: 038948e7134b5cb06f14f102f947edbca89ce38f
Date: 2024-12-03
Guidelines: MISRA C 2012
Checking Tool: Cppcheck
Result: Compliant ✅

🎉 No MISRA C 2012 Violations Found!

You can download the complete report from: MISRA C Report

@AngelCastilloB AngelCastilloB force-pushed the feat/add-cip129-support-to-gov-action branch from 234adb1 to 01cfe8a Compare December 3, 2024 13:53
@AngelCastilloB AngelCastilloB force-pushed the feat/add-cip129-support-to-gov-action branch from 01cfe8a to 8c3af45 Compare December 3, 2024 13:55
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
lib/src/transaction_builder/transaction_builder.c 92.85% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@AngelCastilloB AngelCastilloB merged commit 2ee615d into main Dec 3, 2024
5 of 6 checks passed
@AngelCastilloB AngelCastilloB deleted the feat/add-cip129-support-to-gov-action branch December 3, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant