Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The TimerEvent::AppendTaskHandle event should always be sent before The TimerEvent::FinishTask event. #45

Closed
gamife opened this issue Feb 3, 2023 · 3 comments

Comments

@gamife
Copy link

gamife commented Feb 3, 2023

Describe the bug
When the task instance is running too fast, The TimerEvent::FinishTask event will be sent before The TimerEvent::AppendTaskHandle event. Subsequent task instances will not run again.

To Reproduce
Steps to reproduce the behavior:

  1. add tokio::time::sleep(std::time::Duration::from_secs(2)).await before
    self.send_timer_event(task_id, tmp_task_handler_box).await;
  2. run a repeat task with maxinum_parallel_runnable_num = 1;
  3. If the task instance ends in less then 2 second, it will get parallel_runnable_num>=maxinum_parallel_runnable_num doesn't run it.

Expected behavior
Subsequent task instances can run again.

@BinChengZhao
Copy link
Owner

Thank you @gamife very much for your support of the project. Due to work reasons, it is difficult for me to find time to do the open-source project now. Would like to invite you as the maintainer, I wonder if it is convenient for you

@BinChengZhao
Copy link
Owner

Thank you @gamife very much for your support of the project. Due to work reasons, it is difficult for me to find time to do the open-source project now. Would like to invite you as the maintainer, I wonder if it is convenient for you

@gamife
Copy link
Author

gamife commented Mar 24, 2023

Thank you @gamife very much for your support of the project. Due to work reasons, it is difficult for me to find time to do the open-source project now. Would like to invite you as the maintainer, I wonder if it is convenient for you

Thank you very much for the invitation and for all the hard work you’ve put into this project. However, I don’t have enough experience and my abilities are limited to take on this responsibility. I suggest you find someone else who is capable of taking on this position.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants