feat: add an ability to edit a project gf-88 #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandrvvu
changed the title
perekotypole
reviewed
Sep 2, 2024
sandrvvu
requested review from
what1s1ove,
liza-veis and
yevhenii-hladkov
as code owners
Vitaliistf
reviewed
Sep 2, 2024
GvoFor
reviewed
Sep 2, 2024
apps/frontend/src/pages/projects/components/project-card/styles.module.css
Outdated
Show resolved
Hide resolved
apps/frontend/src/pages/projects/components/project-card/project-card.tsx
Outdated
Show resolved
Hide resolved
liza-veis
requested changes
Sep 2, 2024
| }); | ||
| } | ||
|
|
||
| const projectWithSameName = await this.projectRepository.findByName( |
There was a problem hiding this comment.
as in other places
Suggested change
| const projectWithSameName = await this.projectRepository.findByName( | |
| const existingProject = await this.projectRepository.findByName( |
| projectData.name, | ||
| ); | ||
|
|
||
| if (projectWithSameName && projectWithSameName.getId() !== id) { |
There was a problem hiding this comment.
remove getId method
Suggested change
| if (projectWithSameName && projectWithSameName.getId() !== id) { | |
| if (existingProject && existingProject.toObject().id !== id) { |
GvoFor
reviewed
Sep 3, 2024
apps/frontend/src/libs/components/menu-item/libs/constants/icon-size.constant.ts
Outdated
Show resolved
Hide resolved
apps/frontend/src/libs/hooks/use-popover-state/use-popover-state.hook.ts
Outdated
Show resolved
Hide resolved
apps/frontend/src/pages/projects/components/project-popover/project-popover.tsx
Outdated
Show resolved
Hide resolved
liza-veis
requested changes
Sep 3, 2024
apps/frontend/src/pages/projects/components/project-popover/project-popover.tsx
Outdated
Show resolved
Hide resolved
apps/frontend/src/pages/projects/components/project-popover/project-popover.tsx
Outdated
Show resolved
Hide resolved
apps/frontend/src/pages/projects/components/project-popover/project-popover.tsx
Outdated
Show resolved
Hide resolved
what1s1ove
approved these changes
Sep 4, 2024
perekotypole
reviewed
Sep 4, 2024
apps/frontend/src/libs/components/menu/libs/components/components.ts
Outdated
Show resolved
Hide resolved
liza-veis
requested changes
Sep 4, 2024
apps/frontend/src/pages/projects/components/project-card/project-card.tsx
Outdated
Show resolved
Hide resolved
apps/frontend/src/pages/projects/components/project-card/project-card.tsx
Outdated
Show resolved
Hide resolved
apps/frontend/src/libs/components/menu/libs/components/menu-item/menu-item.tsx
Outdated
Show resolved
Hide resolved
GvoFor
reviewed
Sep 4, 2024
apps/frontend/src/libs/components/menu/libs/components/components.ts
Outdated
Show resolved
Hide resolved
apps/frontend/src/pages/projects/components/project-card/project-card.tsx
Outdated
Show resolved
Hide resolved
liza-veis
approved these changes
Sep 4, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an options icon at the end of the project list item.
When the icon is clicked, an options menu should be opened with an Edit option.
On the Edit item click, a modal should be opened to update a project.
The data for the modal should be prepopulated with the current project data.
The validation is the same as for project creation