Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS files included in published NPM package #29

Closed
JustinSchneider opened this issue May 31, 2017 · 2 comments
Closed

TS files included in published NPM package #29

JustinSchneider opened this issue May 31, 2017 · 2 comments

Comments

@JustinSchneider
Copy link

This is news to me, but apparently NPM packages aren't supposed to contain .ts files. Having them included is causing my 'ng lint' to scrub those files and yell at me for all the whitespace and doublequote issues.

@BioPhoton
Copy link
Owner

BioPhoton commented Jun 3, 2017

Hi @JustinSchneider!

I will try to:

  • fix linting errors,
  • exclude ts from npm

If you want to work in the meantime you could exclude node_modules from linting.

"lint": [
{
"project": "src/tsconfig.app.json",
"exclude": "/node_modules//"
},
{
"project": "src/tsconfig.spec.json",
"exclude": "/node_modules//
"
},
{
"project": "e2e/tsconfig.e2e.json",
"exclude": "/node_modules//*"
}
]

Best Michael

@BioPhoton BioPhoton mentioned this issue Jun 13, 2017
3 tasks
@BioPhoton
Copy link
Owner

Will close this because of finishing #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants