Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images downloaded from zerochan aren't named correctly #2249

Closed
Roshri opened this issue Jan 29, 2021 · 3 comments
Closed

Images downloaded from zerochan aren't named correctly #2249

Roshri opened this issue Jan 29, 2021 · 3 comments
Assignees
Labels
bug reproduced This issue was reproduced by the assignee. source
Milestone

Comments

@Roshri
Copy link

Roshri commented Jan 29, 2021

Bug description

Tried to switch from some of the boorus to zerochan to get some stuff and when I downloaded the files I saw that it doesn't work with the same tokens as the boorus. %artist% %copyright% and %character% don't work at all since everything was listed as the default for unknown sources.

Steps to reproduce

  1. Select zerochan as source
  2. Search anything and download with preferred naming (mine is %artist%\%copyright%\%character%_%date:format=yyyy.MM.dd-hh.mm%_%md5%.%ext%)
  3. Check if the file was named properly
@sstabeler
Copy link

That would be because Zerochan doesn't use the same namespaces as other sites. Mangaka for Artist, for instance. Copyright can be a variety of things, character is the same.

@Roshri
Copy link
Author

Roshri commented Jan 29, 2021

That makes sense, so artist and copyright are out of the picture, I think I can get a workaround by refining searches and then telling grabber to download to a specific directory to keep my naming.
But it is still not pulling character correctly, I only get unknown_md5.ext
But if zerochan is that much different than the boorus then there's probably no workaround for this

@Bionus Bionus self-assigned this Feb 22, 2021
@Bionus Bionus added bug reproduced This issue was reproduced by the assignee. source labels Feb 22, 2021
@Bionus
Copy link
Owner

Bionus commented Feb 22, 2021

There should actually already be some pre-built tag type mappings for Zerochan and a few other sources to work without needing to have to work around them. Those mappings are:

  • idol => model
  • series => copyright
  • mangaka => artist
  • game => copyright
  • studio => circle
  • source => general
  • character group => general
  • oc => character

However, it would seem that they have been broken in a recent update. I'll push a fix ASAP to solve this.

@Bionus Bionus added this to the 7.3.3 milestone Feb 22, 2021
@Bionus Bionus closed this as completed in 96edd5b Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug reproduced This issue was reproduced by the assignee. source
Projects
None yet
Development

No branches or pull requests

3 participants