Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[safebooru, danbooru] Incorrect names given to ratings #2723

Closed
scoliono opened this issue Jun 22, 2022 · 3 comments
Closed

[safebooru, danbooru] Incorrect names given to ratings #2723

scoliono opened this issue Jun 22, 2022 · 3 comments
Assignees
Labels
Milestone

Comments

@scoliono
Copy link

Bug description

Safebooru and Danbooru rating descriptions shown on the websites do not match the abbreviations given in the API. Grabber takes this value directly from the API, potentially affecting the save location of images.

Steps to reproduce

  1. Search id:4054397 on Safebooru

  2. Click 'Details'

  3. Rating shows as 'questionable'

  4. Search id:5450477 on Danbooru

  5. Click 'Details'

  6. Rating shows as 'g'

Expected behavior

In both cases, the rating should show as 'general' like it does on both websites:
https://safebooru.org/index.php?page=post&s=view&id=4054397
https://danbooru.donmai.us/posts/5450477

I suggest adding a setting that configures how ratings in each booru's API get mapped to a %rating% value. The current categories seem to be pretty unreliable anyway. For instance, Gelbooru just made a new 'general' rating and renamed 'safe' to 'sensitive'.

System information

  • OS: Arch Linux
  • Grabber version: 7.9.0

Additional context

According to the Safebooru api, 'q' means 'general' and 's' means 'safe'

@Bionus
Copy link
Owner

Bionus commented Jul 13, 2022

So from what I understand from this post on Danbooru and this post on Gelbooru:

  • g (general) => new 100% SFW, "extra-safe"
  • s (safe) => s (sensitive)
  • q (questionable) => no change
  • e (explicit) => no change

Do I get that right?
BTW, will safebooru now only contain "general" level images? 🤔

@Bionus Bionus added the source label Jul 13, 2022
@Bionus Bionus self-assigned this Jul 13, 2022
@Bionus
Copy link
Owner

Bionus commented Jul 13, 2022

On safebooru, the rating is incorrect because their API returns "rating=q" for this image:
https://safebooru.org/index.php?page=dapi&s=post&q=index&limit=20&pid=0&tags=id:4054397
I guess it's not all very ironed out yet on their end.

I'll fix the "g => general" mapping at least.

@Bionus
Copy link
Owner

Bionus commented Jul 13, 2022

According to the Safebooru api, 'q' means 'general' and 's' means 'safe'

It doesn't really make much sense, given "q" is an already existing shortcut for "questionable". Is this Safebooru-specific? 🤔

@Bionus Bionus added this to the 7.9.1 milestone Jul 13, 2022
@Bionus Bionus closed this as completed in b859ada Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants