Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FurAffinity broken - possible fix included #2784

Closed
tnovak007 opened this issue Aug 14, 2022 · 1 comment
Closed

FurAffinity broken - possible fix included #2784

tnovak007 opened this issue Aug 14, 2022 · 1 comment
Assignees
Labels
bug reproduced This issue was reproduced by the assignee. source
Milestone

Comments

@tnovak007
Copy link

Bug description

Tried to download from Fur Affinity but no images appeared after entering search query.
FurAffinity - No results

Steps to reproduce

  1. Fill a search query in new tab
  2. Click on Ok
  3. Check the results

Expected behavior

Some images will appear after entering a search query

Context

LOG (test search query = "horse"):

[18:17:41.264][Info] [www.furaffinity.net][Html] Loading page https://www.furaffinity.net/search/?q=horse&order-by=date&page=1&perpage=24
[18:17:41.791][Info] [www.furaffinity.net][Html] Receiving page https://www.furaffinity.net/search/?q=horse&order-by=date&page=1&perpage=24
[18:17:41.793][Info] [www.furaffinity.net][Html] Parsed page https://www.furaffinity.net/search/?q=horse&order-by=date&page=1&perpage=24: 0 images (0), 0 tags (0), 448623 total (448623), 18693 pages (18693)

System information

  • OS: Windows 10
  • Grabber version: 7.9.1

Possible fix

I think I found the bug source (FA code change) and tried to fix it by changing line 29 in C:\Program Files\Grabber\sites\FurAffinity\model.js from

images: Grabber.regexToImages('<figure id="sid-(?<id>\\d+)" class="r-(?<rating>[^"]+) t-image u-(?<author>[^"]+)">.+?<img.+?src="(?<preview_url>[^"]+)"\\s*data-width="(?<preview_width>[0-9.]+)"\\s*data-height="(?<preview_height>[0-9.]+)"', src),

to

images: Grabber.regexToImages('<figure id="sid-(?<id>\\d+)" class="r-(?<rating>[^"]+) t-image u-(?<author>[^"]+) .+?<img.+?src="(?<preview_url>[^"]+)"\\s*data-width="(?<preview_width>[0-9.]+)"\\s*data-height="(?<preview_height>[0-9.]+)"', src),

Seems to be fixed after the change:

[18:28:18.075][Info] [www.furaffinity.net][Html] Loading page https://www.furaffinity.net/search/?q=horse&order-by=date&page=1&perpage=24
[18:28:18.635][Info] [www.furaffinity.net][Html] Receiving page https://www.furaffinity.net/search/?q=horse&order-by=date&page=1&perpage=24
[18:28:18.639][Info] [www.furaffinity.net][Html] Parsed page https://www.furaffinity.net/search/?q=horse&order-by=date&page=1&perpage=24: 23 images (23), 0 tags (0), 448623 total (448623), 18693 pages (18693)
@tnovak007 tnovak007 added the bug label Aug 14, 2022
@Bionus Bionus added source reproduced This issue was reproduced by the assignee. labels Dec 14, 2022
@Bionus Bionus added this to the 7.10.0 milestone Dec 14, 2022
@Bionus Bionus self-assigned this Dec 14, 2022
@Bionus
Copy link
Owner

Bionus commented Dec 14, 2022

Hey, sorry for the very delayed reply.
Seems like they indeed added a new metadata during search which broke the parsing.

Your fix works, thanks for that! I'll include it or something similar in the next release 👍

@Bionus Bionus closed this as completed in ddadd2d Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug reproduced This issue was reproduced by the assignee. source
Projects
None yet
Development

No branches or pull requests

2 participants