Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplication of Added Tag for individual source when downloading #2840

Closed
Eddyall-1 opened this issue Nov 17, 2022 · 0 comments
Closed

Duplication of Added Tag for individual source when downloading #2840

Eddyall-1 opened this issue Nov 17, 2022 · 0 comments
Assignees
Labels
bug reproduced This issue was reproduced by the assignee.
Milestone

Comments

@Eddyall-1
Copy link
Contributor

Bug description

Having an added tag in Danbooru as a source duplicates them when trying to download, making it fail to do anything due to the 2 tags limit. Issue is also present in Gelbooru and likely others but has not caused buggy behaviour for them.

Steps to reproduce

  1. Go to Sources > Danbooru > Options
  2. Set an added tag such as "order:id"
  3. Search for any artist
  4. Click Get All to set a download for the results
  5. Go to Downloads
  6. Download the search
  7. Go to Log
  8. Observe that the download attempt was made with 3 tags, the artist + twice order:id

Expected behavior

Added tags are added once for download result and not twice
OR
Duplicated tags in a download could be automatically merged

Context

DanbooruBugLog.txt

Screenshots

image

System information

  • OS: Mint 20.3 Cinnamont
  • Grabber version: 7.9.1

Additional context

Issue also happen with Gelbooru but does not cause issues so far, however it showcase that for each page it's trying to load, the added tag sort:id:asc is being re-added.
GelbooruBugLog.txt

@Eddyall-1 Eddyall-1 added the bug label Nov 17, 2022
@Bionus Bionus self-assigned this Dec 9, 2022
@Bionus Bionus added this to the 7.9.2 milestone Dec 9, 2022
@Bionus Bionus added the reproduced This issue was reproduced by the assignee. label Dec 9, 2022
@Bionus Bionus closed this as completed in e7bf3f3 Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug reproduced This issue was reproduced by the assignee.
Projects
None yet
Development

No branches or pull requests

2 participants