Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E-Hentai only showing first page #2880

Closed
legacy036036 opened this issue Jan 4, 2023 · 2 comments
Closed

E-Hentai only showing first page #2880

legacy036036 opened this issue Jan 4, 2023 · 2 comments
Assignees
Labels
bug reproduced This issue was reproduced by the assignee. source
Milestone

Comments

@legacy036036
Copy link

Bug description

Of any tag of E-Hentai, choosing to go to the next page only gives the results from the first page no matter what.

Steps to reproduce

  1. Use any tag (or no tag) on E-Hentai.
  2. Attempt to go to a different page.
  3. Result from the first page will still be there.

Expected behavior

A clear and concise description of what you expected to happen.

Context

  • Provide your main.log file to see if any obvious error occurred.
  • Providing your settings.ini file will greatly help maintainers reproduce your problem if it may be caused by your configuration.
  • If the bug occurred during a download, make sure to provide said download as an .igl file that Grabber can generate by clicking the Save button of the Downloads tab.

[23:40:16.392][Info] Loading results...
[23:40:16.395][Info] [e-hentai.org][Html] Loading page https://e-hentai.org/?page=0&f_cats=0&f_search=test
[23:40:16.614][Info] [e-hentai.org][Html] Receiving page https://e-hentai.org/?page=0&f_cats=0&f_search=test
[23:40:16.653][Info] [e-hentai.org][Html] Parsed page https://e-hentai.org/?page=0&f_cats=0&f_search=test: 25 images (25), 0 tags (138), -1 total (-1), -1 pages (-1)
[23:40:18.560][Info] Loading results...
[23:40:18.564][Info] [e-hentai.org][Html] Loading page https://e-hentai.org/?page=1&f_cats=0&f_search=test
[23:40:18.760][Info] [e-hentai.org][Html] Receiving page https://e-hentai.org/?page=1&f_cats=0&f_search=test
[23:40:18.804][Info] [e-hentai.org][Html] Parsed page https://e-hentai.org/?page=1&f_cats=0&f_search=test: 25 images (25), 0 tags (138), -1 total (-1), -1 pages (-1)

First being page 1, second being page 2. Same results

System information

  • OS: Windows 10
  • Grabber version: [e.g. 7.10] (most recent stable)

Additional context

Appreciate all of your hard work! Thanks! :)

@Bionus Bionus added source reproduced This issue was reproduced by the assignee. labels Mar 1, 2023
@Bionus Bionus self-assigned this Mar 1, 2023
@Bionus
Copy link
Owner

Bionus commented Mar 1, 2023

Seems to be caused by this: https://forums.e-hentai.org/index.php?showtopic=261743
They changed the search system, and the pagination system with it.

The most significant and visible fundamental change is that the internal segmenting of search results is now done by gallery ID (GID) ranges rather than "pages". While this means jumping to an arbitrary "page" in the result is no longer supported, this is arguably an improvement since you can now jump to an arbitrary GID instead. This also means each page of results will be fixed on the same set of galleries even if it is refreshed after new galleries are added. The page navigation has been reworked to reflect this.

@Bionus Bionus added this to the 7.10.2 milestone Mar 1, 2023
@aqpaqp
Copy link

aqpaqp commented Apr 15, 2023

Thanks, I've been waiting for this fix for a long time

@Bionus Bionus closed this as completed in 31a40b3 Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug reproduced This issue was reproduced by the assignee. source
Projects
None yet
Development

No branches or pull requests

3 participants