Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'no source found' error with Grabber_v7.10.1-x86_64.AppImage when running in portable mode if 'sites' directory exists #2936

Closed
aoibonzie opened this issue Mar 19, 2023 · 1 comment
Assignees
Labels
bug linux reproduced This issue was reproduced by the assignee.
Milestone

Comments

@aoibonzie
Copy link

Bug description

When started in portable mode 'Grabber_v7.10.1-x86_64.AppImage' will produce a 'no source found' error if the 'sites' directory exists.

Steps to reproduce

  1. Download 'Grabber_v7.10.1-x86_64.AppImage' to Desktop on clean Ubuntu 20.04 system with no previous imgbrd-grabber install or use
  2. Run 'Grabber_v7.10.1-x86_64.AppImage' for first time and follow basic initialization flow - 'sites' directory will get created with config for safebooru
  3. Close 'Grabber_v7.10.1-x86_64.AppImage'
  4. Open 'Grabber_v7.10.1-x86_64.AppImage' again and verify that it works, then close it again
  5. cp -r ~/.config/Bionus/Grabber ~/Desktop/
  6. mv ~/Desktop/Grabber_v7.10.1-x86_64.AppImage ~/Desktop/Grabber/
  7. Run ~/Desktop/Grabber/Grabber_v7.10.1-x86_64.AppImage and get 'no source found' error
  8. rm -r ~/Desktop/Grabber/sites/
  9. Run ~/Desktop/Grabber/Grabber_v7.10.1-x86_64.AppImage and 'no source found' error is gone - at least until 'sites' directory gets recreated

Expected behavior

It is expected that 'Grabber_v7.10.1-x86_64.AppImage' would not generate 'no source found' errors when run in portable mode simply because the 'sites' directory exists.

Context

Possibly valuable:

[12:51:20.602][Warning] Javascript 'model.js' file not found for 'Gelbooru (0.2)' in `/home/user/Desktop/Grabber/sites/Gelbooru (0.2)/model.js
[12:51:20.648][Error] JavaScript helper file could not be opened 

System information

Ubuntu 20.04

Thank you for creating and maintaining this software.

@aoibonzie aoibonzie added the bug label Mar 19, 2023
@Bionus Bionus added the reproduced This issue was reproduced by the assignee. label Mar 26, 2023
@Bionus Bionus self-assigned this Mar 26, 2023
@Bionus Bionus added this to the 7.10.2 milestone Mar 26, 2023
@Bionus Bionus added the linux label Mar 26, 2023
@Bionus
Copy link
Owner

Bionus commented Mar 26, 2023

Indeed, portable mode expects a fully portable application, while AppImages should still read from their embedded filesystem.
I'll fix that so that AppImages prioritize their own filesystem for reads over the directory they're put in (that they should still use for read overrides and writes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug linux reproduced This issue was reproduced by the assignee.
Projects
None yet
Development

No branches or pull requests

2 participants