alternate cat def merge function #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BirdeeHub
added a commit
that referenced
this pull request
Oct 29, 2024
This one is capable of merging duplicate lists together. This allows for defining extensions to existing categories, rather than the only option being to completely replace with a new list `utils.deepmergeCats` is the new merge function, used the same way as `utils.mergeCatDefs` In addition, module options for categoryDefininions have been slightly changed. `categoryDefinitions.replace` still uses `utils.mergeCatDefs` and merge now uses `utils.deepmergeCats` Using `categoryDefinitions.replace` option no longer is what controls if definitions from the package the module was based on are inherited. Instead, an extra option has been added, `categoryDefinitions.existing` to allow you to control the merge strategy used for merging with the existing definitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is capable of merging duplicate lists together. This allows for defining extensions to existing categories, rather than the only option being to completely replace with a new list
utils.deepmergeCats is the new merge function, used the same way as utils.mergeCatDefs
In addition, module options for categoryDefininions have been slightly changed.
replace still uses mergeCatDefs and merge now uses utils.deepmergeCats
Using replace no longer is what controls if definitions from the package the module was based on are inherited.
Instead, an extra option has been added, to allow you to control the merge strategy used for merging with the existing definitions.