Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request data lost using "normal express middleware" #188

Open
jonball4 opened this issue Aug 4, 2022 · 0 comments
Open

Request data lost using "normal express middleware" #188

jonball4 opened this issue Aug 4, 2022 · 0 comments

Comments

@jonball4
Copy link
Contributor

jonball4 commented Aug 4, 2022

Middleware that modifies req (normal express middleware) runs, and modifies req, but the modified req never gets to the handler, only the empty middleware output.

Middleware that returns data, works fine.

Referencing the only test for the normal express middleware here since it's a no-op and never changed the request data:

const noopMiddleware: express.RequestHandler = (_req, _res, next) => {

The test should be enhanced to cover a realistic use case, which would have highlighted this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant