-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy as Markdown not escaping some characters #5
Comments
It's obviously confusing to ask an error about Markdown on a platform that supports Markdown, so I tried to display these in code syntax: original HTML <em>F*ck, what is going on?</em> should be *F\*ck, what is going on?* not *F*ck, what is going on?* After my check, this is indeed a problem with Turndown. When I upgraded to Turndown 5.0.0, the problem was solved. Thank you for your reminder, please wait for me to release Copycat 2.4.1. |
Still not escaping angle brackets. Original: Source: Becomes: and Original: Source: Becomes: ....nothing. I did see a comment talking about more aggressive escaping rules (which included angle brackets) which didn't make it into the 5.0.0 release, so maybe it's possible with that custom rule? Currently, if the formatted text includes |
Copycat will decode HTML character entities into ordinary characters in advance, which causes this problem. After I removed the code that decoded HTML entities, the problem was solved, it will be released as version 2.4.2. |
If the text itself includes asterisks or angle-brackets, they aren't escaped into * or < >
So the resulting markdown doesn't match the original. That is to say, this italicized and censored internal thought:
F*ck, what is going on?
becomes:
Fck, what is going on?*
The asterisk in the text isn't escaped, so it's treated as markdown when it shouldn't be.
This looks like it might be a Turndown issue, as escaping was fixed in the recent 5.0.0 release, so if you're using a version older than that you'll have the same bugs.
The text was updated successfully, but these errors were encountered: