Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX Bug: BIP39 word entry #186

Closed
ChristopherA opened this issue Jun 3, 2023 · 8 comments
Closed

UX Bug: BIP39 word entry #186

ChristopherA opened this issue Jun 3, 2023 · 8 comments
Assignees
Labels
retest Fixed in recent or next release, or OS release ux User experience or interface

Comments

@ChristopherA
Copy link
Contributor

There is a difference between reporting an invalid bip39 word vs the checksum being invalid. User was legitimately confused thinking the world was invalid.

IMG_1640

Error shown be more granular: incorrect word, insufficient quantity of words, checksum invalid.

@ChristopherA
Copy link
Contributor Author

We should make a bigger test case for BIP39 seeds. Extra spaces, extra at end or beginning, comma, comma space (or not), CR or CR/LF between. Both full word and 4 characters words. We should make it as easy as possible to bring in old seeds.

@shannona
Copy link
Contributor

Comma separated, space separated, tab separated, and return separated all work in GST 1.6.

I think the major UI issue here is that GST will report "Invalid BIP39 words." as you're typing them in, up to the point where you have a complete, valid set added.

@shannona shannona added the ux User experience or interface label Jul 13, 2023
@wolfmcnally wolfmcnally added the retest Fixed in recent or next release, or OS release label Jul 15, 2023
@wolfmcnally
Copy link
Collaborator

Please retest in next release.

@shannona
Copy link
Contributor

I'm still seeing errors as you type words in, @wolfmcnally , both in the 4-letter form and complete form, only clearing when the last letter of the last word is typed.

IMG_6209

@shannona
Copy link
Contributor

Minor suggestion on "No valid SSKR shares found" error message. We should add the word: "yet", ie, "No valid SSKR shares found yet".

2FF46B5C-638E-430E-9C82-91ACA852D3F1

@shannona
Copy link
Contributor

A bigger issue: when an error appears, it sticks around. So after I accidentally mistyped "fly" and "fky", I got an "Invalid BIP39 words" message, but it didn't go away when my iPhone helpfully corrected that word.

DD1583CD-AEC3-4544-840B-B25B9B875D25

@shannona
Copy link
Contributor

shannona commented Jan 4, 2024

This still shows "Invalid BIP39 words." as you're typing in correct BIP39 words.

@shannona
Copy link
Contributor

The new red/green/yellow words at bottom are amazing and should be a great UI for entering words. I think we still need to change the error message though.

I suggest "Invalid BIP39 words" only if something comes up red.
Otherwise, maybe "BIP39 word import not complete" or "BIP39 words incomplete".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
retest Fixed in recent or next release, or OS release ux User experience or interface
Projects
None yet
Development

No branches or pull requests

3 participants